Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use peer reputation to compare current peers #7616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

macfarla
Copy link
Contributor

PR description

use reputation score to sort peers within EthPeers (bestPeerComparator)

Note in a few places in tests I've explicitly set the comparator to what was used before (uses chain height estimate) to avoid having to update a heap of tests that are dependent on the decision made by the comparator
ref #6968

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
Copy link
Contributor Author

2 nodes off this PR vs 24.9.0 as control. 1 node taking much longer to get in sync so that is not a great endorsement
Screenshot 2024-09-17 at 11 02 03 AM

same node took longer to get to max peers
Screenshot 2024-09-17 at 11 01 33 AM

Copy link

github-actions bot commented Nov 8, 2024

This pr is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant